Skip to content

Fix parsing Python interpreter info containing non-UTF8 chars#1141

Merged
j178 merged 1 commit intomasterfrom
python-info-non-utf8
Nov 22, 2025
Merged

Fix parsing Python interpreter info containing non-UTF8 chars#1141
j178 merged 1 commit intomasterfrom
python-info-non-utf8

Conversation

@j178
Copy link
Owner

@j178 j178 commented Nov 22, 2025

Closes #1139

@j178 j178 added the bug Something isn't working label Nov 22, 2025
@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (e84a843) to head (f32eb8c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
- Coverage   89.67%   89.66%   -0.01%     
==========================================
  Files          74       74              
  Lines       13769    13758      -11     
==========================================
- Hits        12347    12336      -11     
  Misses       1422     1422              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

📦 Cargo Bloat Comparison

Binary size change: +0.00% (16.3 MiB → 16.3 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size          Crate Name
 0.7%   1.5% 114.9KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.6%   1.3% 101.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.7%  54.6KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.6%  49.6KiB           prek prek::run::{{closure}}
 0.2%   0.5%  39.2KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  37.3KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.5%  34.6KiB           prek prek::workspace::Workspace::discover
 0.2%   0.4%  32.5KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.4%  31.6KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.4%  30.5KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  30.4KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.4%  30.4KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.4%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.2%   0.3%  25.5KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::connect_to::{{closure}}::{{closure}}::{{closure}}
 0.2%   0.3%  25.1KiB           prek prek::main
 0.1%   0.3%  24.9KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::send_request::{{closure}}
 0.1%   0.3%  24.8KiB           prek prek::hook::HookBuilder::build::{{closure}}
 0.1%   0.3%  24.4KiB           std? <core::marker::PhantomData<T> as serde_core::de::DeserializeSeed>::deserialize
 0.1%   0.3%  24.2KiB           prek prek::cli::run::run::run_hooks::{{closure}}
 0.1%   0.3%  24.2KiB           prek prek::languages::golang::installer::GoInstaller::install::{{closure}}
40.6%  88.7%   6.6MiB                And 10248 smaller methods. Use -n N to show more.
45.8% 100.0%   7.5MiB                .text section size, the file size is 16.3MiB

Base Branch Results

 File  .text     Size          Crate Name
 0.7%   1.5% 114.9KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.6%   1.3% 101.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.7%  54.6KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.7%  49.6KiB           prek prek::run::{{closure}}
 0.2%   0.5%  39.2KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  37.3KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.5%  34.6KiB           prek prek::workspace::Workspace::discover
 0.2%   0.4%  32.5KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.4%  32.3KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.4%  31.6KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.4%  30.5KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  30.4KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.4%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.2%   0.3%  25.5KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::connect_to::{{closure}}::{{closure}}::{{closure}}
 0.2%   0.3%  25.1KiB           prek prek::main
 0.1%   0.3%  24.9KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::send_request::{{closure}}
 0.1%   0.3%  24.8KiB           prek prek::hook::HookBuilder::build::{{closure}}
 0.1%   0.3%  24.4KiB           std? <core::marker::PhantomData<T> as serde_core::de::DeserializeSeed>::deserialize
 0.1%   0.3%  24.2KiB           prek prek::cli::run::run::run_hooks::{{closure}}
 0.1%   0.3%  24.2KiB           prek prek::languages::golang::installer::GoInstaller::install::{{closure}}
40.6%  88.7%   6.6MiB                And 10257 smaller methods. Use -n N to show more.
45.8% 100.0%   7.5MiB                .text section size, the file size is 16.3MiB

@j178 j178 merged commit 542fbe8 into master Nov 22, 2025
21 checks passed
@j178 j178 deleted the python-info-non-utf8 branch November 22, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't install hooks "Failed to query Python info"

1 participant