Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1333 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 80 80
Lines 15914 15910 -4
=======================================
- Hits 14331 14328 -3
+ Misses 1583 1582 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBinary size change: +0.00% (16.7 MiB → 16.7 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the generated git hook scripts by switching from bash to POSIX sh, making them more portable and removing platform-specific conditional logic.
Changes:
- Changed shebang from
#!/usr/bin/env bash(with Windows-specific handling) to#!/bin/shfor all platforms - Replaced bash array syntax with direct argument construction for better POSIX sh compatibility
- Updated all test snapshots to reflect the new script format
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/prek/src/cli/install.rs | Modified hook script template to use /bin/sh shebang and replaced bash array argument construction with direct command-line argument passing |
| crates/prek/tests/install.rs | Updated all test snapshots to expect /bin/sh shebang and the new argument format without bash arrays |
| crates/prek/tests/common/mod.rs | Removed the test filter that was converting #!/bin/sh to #!/usr/bin/env bash |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1323