Conversation
Just realized that [`cargo-binstall`](https://github.com/cargo-bins/cargo-binstall) also installs things into `~/.cargo/bin`, so there’s no (easy) way to tell whether something was installed with `cargo install` or `cargo binstall`. Partially reverts #1540
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1544 +/- ##
=======================================
Coverage 91.56% 91.57%
=======================================
Files 91 91
Lines 17892 17873 -19
=======================================
- Hits 16383 16367 -16
+ Misses 1509 1506 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Cargo install source detection from the InstallSource enum because cargo-binstall also installs binaries to ~/.cargo/bin, making it impossible to reliably differentiate between cargo install and cargo binstall installations. This partially reverts PR #1540.
Changes:
- Removed the
InstallSource::Cargoenum variant, leaving onlyHomebrew - Removed the detection logic that checked for
.cargo/binin executable paths - Removed tests related to Cargo install source detection
📦 Cargo Bloat ComparisonBinary size change: +0.00% (23.2 MiB → 23.2 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just realized that
cargo-binstallalso installs things into~/.cargo/bin, so there’s no (easy) way to tell whether something was installed withcargo installorcargo binstall.Partially reverts #1540