Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #900 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 62 62
Lines 11552 11558 +6
=======================================
+ Hits 10374 10380 +6
Misses 1178 1178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could you please give more details about the solution? This feels like a harsh workaround. I'm missing why this should be ignored if the user prefers to work with uv. |
|
This isn't a workaround. Prek uses uv as a library, so you can think of uv as part of prek itself. I want this component's logic to be completely controlled by prek, without any interference from external user configurations. So when prek uses uv, it should operate with completely independent cache directories and Python install directories. Here's the issue: prek already uses In this case, I think it makes sense to ignore the user's |
|
I think I mostly disagree with this part:
I'd expect that prek, or any other similar tool, does the minimum possible work related to the env and other tools, and respect the user preferences. |
|
Sorry, I take back what I said earlier - I lost my cool there. You’re totally right to be concerned, but the thing is, prek just can’t work the way you’re thinking right now. I’m definitely open to changing it though - if you anyone can figure out how to make it work. |
|
That's okay, sorry if I came too hot with the feedback. I don't have a way to contribute code right now but I'll try to support in a way I can do if I can find one. |
Closes #899