Add collision detection for hook env directories#914
Merged
j178 merged 2 commits intoj178:masterfrom Oct 17, 2025
Merged
Conversation
Signed-off-by: kenwoodjw <blackxin55+@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #914 +/- ##
==========================================
+ Coverage 89.98% 90.10% +0.11%
==========================================
Files 63 64 +1
Lines 11756 11944 +188
==========================================
+ Hits 10579 10762 +183
- Misses 1177 1182 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use tempfile to do the collision detection, and avoid [TOCTOU](https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use) issue
Owner
|
Thanks for working on this! I switched to using tempfile for more reliable detection and to create the directory safely. This helps avoid TOCTOU issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #325