Skip to content

Add collision detection for hook env directories#914

Merged
j178 merged 2 commits intoj178:masterfrom
kenwoodjw:fix/hook-dir-collision
Oct 17, 2025
Merged

Add collision detection for hook env directories#914
j178 merged 2 commits intoj178:masterfrom
kenwoodjw:fix/hook-dir-collision

Conversation

@kenwoodjw
Copy link
Contributor

Closed #325

Signed-off-by: kenwoodjw <blackxin55+@gmail.com>
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.10%. Comparing base (054e1fb) to head (a99db78).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/languages/docker.rs 0.00% 1 Missing ⚠️
src/languages/golang/golang.rs 0.00% 1 Missing ⚠️
src/languages/node/node.rs 0.00% 1 Missing ⚠️
src/languages/pygrep/pygrep.rs 0.00% 1 Missing ⚠️
src/languages/python/python.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
+ Coverage   89.98%   90.10%   +0.11%     
==========================================
  Files          63       64       +1     
  Lines       11756    11944     +188     
==========================================
+ Hits        10579    10762     +183     
- Misses       1177     1182       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j178 j178 changed the title fix: Add collision detection for hook env directories Add collision detection for hook env directories Oct 17, 2025
@j178 j178 added the enhancement New feature or request label Oct 17, 2025
@j178
Copy link
Owner

j178 commented Oct 17, 2025

Thanks for working on this! I switched to using tempfile for more reliable detection and to create the directory safely. This helps avoid TOCTOU issues.

@j178 j178 merged commit f81d30c into j178:master Oct 17, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More robust hook direcotry generation

2 participants