chore: update imports to prevent shadowing internal exceptions

jasgnft · Nov 25, 2024 · 748233c · 748233c
1 parent 8c6283a
commit 748233c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ft_client/freqtrade_client/ft_rest_client.py b/ft_client/freqtrade_client/ft_rest_client.py
@@ -12,7 +12,7 @@
 
 import requests
 from requests.adapters import HTTPAdapter
-from requests.exceptions import ConnectionError
+from requests.exceptions import ConnectionError as RequestConnectionError
 
 
 logger = logging.getLogger("ft_rest_client")
@@ -53,7 +53,7 @@ def _call(self, method, apipath, params: dict | None = None, data=None, files=No
             resp = self._session.request(method, url, headers=hd, data=json.dumps(data))
             # return resp.text
             return resp.json()
-        except ConnectionError:
+        except RequestConnectionError:
             logger.warning(f"Connection error - could not connect to {netloc}.")
 
     def _get(self, apipath, params: ParamsT = None):

diff --git a/ft_client/test_client/test_rest_client.py b/ft_client/test_client/test_rest_client.py
@@ -2,7 +2,7 @@
 from unittest.mock import ANY, MagicMock
 
 import pytest
-from requests.exceptions import ConnectionError
+from requests.exceptions import ConnectionError as RequestsConnectionError
 
 from freqtrade_client import FtRestClient
 from freqtrade_client.ft_client import add_arguments, main_exec
@@ -45,7 +45,7 @@ def test_FtRestClient_call_invalid(caplog):
     with pytest.raises(ValueError):
         client._call("PUTTY", "/dummytest")
 
-    client._session.request = MagicMock(side_effect=ConnectionError())
+    client._session.request = MagicMock(side_effect=RequestsConnectionError())
     client._call("GET", "/dummytest")
 
     assert log_has_re("Connection error", caplog)