make yychar long #558
make yychar long #558
Conversation
…files larger than 2GB. Closes #536
Markdown syntax
jflex/changelog.md
Outdated
| ## [JFlex 1.8.0](https://github.com/jflex-de/jflex/milestone/11) | ||
| - Unicode 10.0 and 11.0 are supported (#540, #555) | ||
| - Unicode Emoji properties are supported for Unicode versions 8.0+ (#546) | ||
| - make yychar long to enable scanners with the %char option to consume files larger than 2GB (#536) |
There was a problem hiding this comment.
nit: you could also format yychar and %char was coe with ``
| @@ -0,0 +1 @@ | |||
| Over2GbInput.java | |||
There was a problem hiding this comment.
Generated files shouldn't be in src/test
There was a problem hiding this comment.
This file is the over-2GB input file generator; it is not itself generated.
| @@ -0,0 +1 @@ | |||
| Over2GbInput.java | |||
There was a problem hiding this comment.
Also, I think you didn't intent to submit Over2GbInput-0.input
There was a problem hiding this comment.
I did mean to, actually. This is the input file that is over 2GB. It would be better to generate it at test time, though that will slow the test down quite a bit. I'll look into generating at test time.
There was a problem hiding this comment.
OK, I think such a large file in git is not a good idea. I think a quick workaround is to zip that file, and open the zipped version in the test.
|
Hmmm, I've been trying to reproduce the bug, and if the consumer doesn't read yychar, then nothing bad happens. |
|
Please see #605 |
make yychar long to enable scanners with the %char option to consume files larger than 2GB. Closes #536