Apply suggestions from code review

jizecn · Sep 3, 2020 · 4ce1378 · 4ce1378
1 parent 043130c
commit 4ce1378
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/_includes/header.html b/_includes/header.html
@@ -5,7 +5,7 @@
     <div class="container">
       {% if page.title != "about" %}
       <a class="navbar-brand title font-weight-lighter" href="{{ site.baseurl | prepend: site.url }}/">
-       <span class="font-weight-bold">{{ site.first_name }}</span> {{ site.middle_name }}  {{ site.last_name }}
+       {% if site.title %}{{ site.title }}{% else %}<span class="font-weight-bold">{{ site.first_name }}</span> {{ site.middle_name }}  {{ site.last_name }}{% endif %}
       </a>
       {% elsif site.show_social_icons %}
         <!-- Social Icons -->

diff --git a/_layouts/about.html b/_layouts/about.html
@@ -6,7 +6,7 @@
 
   <header class="post-header">
     <h1 class="post-title">
-     <span class="font-weight-bold">{{ site.first_name }}</span> {{ site.middle_name }}  {{ site.last_name }}
+     {% if site.title %}{{ site.title }}{% else %}<span class="font-weight-bold">{{ site.first_name }}</span> {{ site.middle_name }}  {{ site.last_name }}{% endif %}
     </h1>
   </header>