Add an optional on upload callback to Upload.Multi.handle_changes/5#10
Merged
JohnDoneth merged 5 commits intomasterfrom Apr 29, 2025
Merged
Add an optional on upload callback to Upload.Multi.handle_changes/5#10JohnDoneth merged 5 commits intomasterfrom
JohnDoneth merged 5 commits intomasterfrom
Conversation
gtronset
approved these changes
Apr 24, 2025
gtronset
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding the test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds off of work in #9
Problem
Some side-effects only need to be triggered when a blob has been uploaded, such as inserting a background job for further processing.
Solution
Add a "on_upload" callback that is fired when the blob record has actually changed. This adds a new operation to the base Multi being modified.