Skip to content

feat: implement Validate for Cow#108

Merged
jprochazk merged 1 commit intojprochazk:mainfrom
bonofiglio:main
Jun 9, 2024
Merged

feat: implement Validate for Cow#108
jprochazk merged 1 commit intojprochazk:mainfrom
bonofiglio:main

Conversation

@bonofiglio
Copy link
Contributor

Implements the Validate trait for Cow when the type it's wrapping implements Validate already, similar to all the other smart pointer types.

@bonofiglio
Copy link
Contributor Author

The nightly test task seems to be failing due to a mismatch in the output of the ui/compile-fail/pattern_mismatched_types.rs test.
This fails the same way when my change is not present when I run it locally, so I'm guessing it's a matter of rustc's version.
The output is the same, but there are two lines that switched places here:

Expected

   = help: the following other types implement trait `Matcher`:
            once_cell::sync::Lazy<T>
            Regex

Actual

   = help: the following other types implement trait `Matcher`:
            Regex
            once_cell::sync::Lazy<T>

I'm not sure how to proceed.

@jprochazk jprochazk merged commit 8662bd9 into jprochazk:main Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants