Make parseRemoteAddr handle IPv6 addresses#389
Open
mikkeloscar wants to merge 1 commit intojtblin:mainfrom
Open
Make parseRemoteAddr handle IPv6 addresses#389mikkeloscar wants to merge 1 commit intojtblin:mainfrom
mikkeloscar wants to merge 1 commit intojtblin:mainfrom
Conversation
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes the function
parseRemoteAddrto be compatible with both IPv4 and IPv6 addresses. This enables kube2iam to work in an IPv6 enabled cluster where the pod IPs and thereby source IP/RemoteAddr would be IPv6. Without the fix, the RemoteAddr is parsed as""and is not mapped to the pod making the call.Additionally it adds the address to an error so it's easier to debug issues.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes:
Checklist chart
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]