[CodeHealth] Remove expired OSX.SystemHotkeyMap.LoadSuccess histogram

Part of the Chrome code health rotation, this CL removes the expired OSX.SystemHotkeyMap.LoadSuccess histogram and cleans up its usages. OBSOLETE_HISTOGRAM[OSX.SystemHotkeyMap.LoadSuccess]=expired. Fixed: 1499462 Change-Id: Iffd5b90f740419316f482f425ebffbd7b5d915b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5063433 Commit-Queue: Richard Chen <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Jimmy Gong <[email protected]> Cr-Commit-Position: refs/heads/main@{#1230237}
junyujian · Nov 28, 2023 · 1663744 · 1663744
1 parent 492e270
commit 1663744
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/content/browser/cocoa/system_hotkey_helper_mac.mm b/content/browser/cocoa/system_hotkey_helper_mac.mm
@@ -6,7 +6,6 @@
 
 #include "base/apple/foundation_util.h"
 #include "base/files/file_path.h"
-#include "base/metrics/histogram_macros.h"
 #include "base/no_destructor.h"
 #include "content/browser/cocoa/system_hotkey_map.h"
 
@@ -22,8 +21,7 @@
       [NSDictionary dictionaryWithContentsOfURL:hotkey_plist_url error:nil];
 
   content::SystemHotkeyMap map;
-  bool success = map.ParseDictionary(dictionary);
-  UMA_HISTOGRAM_BOOLEAN("OSX.SystemHotkeyMap.LoadSuccess", success);
+  map.ParseDictionary(dictionary);
   return map;
 }
 

diff --git a/tools/metrics/histograms/metadata/others/histograms.xml b/tools/metrics/histograms/metadata/others/histograms.xml
@@ -7398,14 +7398,6 @@ [email protected].
   </summary>
 </histogram>
 
-<histogram name="OSX.SystemHotkeyMap.LoadSuccess" enum="BooleanSuccess"
-    expires_after="2018-08-30">
-  <owner>[email protected]</owner>
-  <summary>
-    Whether an attempt to load the system hotkeys on a Mac was successful.
-  </summary>
-</histogram>
-
 <histogram name="Ozone.NeuralStylusReport.ActivePalmTouchCount"
     units="touch event count" expires_after="2023-06-30">
   <owner>[email protected]</owner>