Skip to content

When adapting also log the version jupyter_client is expecting. #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minrk merged 2 commits into from
Oct 10, 2018
Merged

When adapting also log the version jupyter_client is expecting. #4034

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e140c5
When adapting also log the version jupyter_client is expecting.
Carreau Sep 26, 2018
96cb061
More descriptive message.
Carreau Sep 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
More descriptive message.
  • Loading branch information
@Carreau
Carreau authored Sep 26, 2018
commit 96cb061e7b6000ae3d3d3d5da3c9050b80bf0d7a
2 changes: 1 addition & 1 deletion notebook/services/kernels/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def _finish_kernel_info(self, info):
protocol_version = info.get('protocol_version', client_protocol_version)
if protocol_version != client_protocol_version:
self.session.adapt_version = int(protocol_version.split('.')[0])
self.log.info("Adapting to protocol v%s for kernel %s (client expecting %s)", protocol_version, self.kernel_id, client_protocol_version)
self.log.info("Adapting from protocol version {protocol_version} (kernel {kernel_id}) to {client_protocol_version} (client).".format(protocol_version=protocol_version, kernel_id=self.kernel_id, client_protocol_version=client_protocol_version))
if not self._kernel_info_future.done():
self._kernel_info_future.set_result(info)

Expand Down