Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Changes for handling/customizing shortcuts via traitlet variables and a coverage upload fix #621

Open
wants to merge 61 commits into
base: main
Choose a base branch
from
Open

PR: Changes for handling/customizing shortcuts via traitlet variables and a coverage upload fix #621

wants to merge 61 commits into from

Conversation

jsbautista
Copy link
Contributor

@jsbautista jsbautista commented Sep 2, 2024 •
edited by dalthviz
Loading

  • Adds a way to customize actions shortcuts via traitlet variables
  • Fixes coverage upload flakiness

Preview:
PreviewShortCuts

@jsbautista jsbautista changed the title [PR] : Changes for handling Shortcuts with traitlets in consoleWidget [WIP] PR: Changes for handling Shortcuts with traitlets in consoleWidget Sep 2, 2024
dalthviz
dalthviz reviewed Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @jsbautista for your work here! Added some suggestions that should prevent the changes here to cause a segfault. If you have any question about the suggested changes let me know!

qtconsole/console_widget.py Outdated Show resolved Hide resolved
qtconsole/console_widget.py Outdated Show resolved Hide resolved
qtconsole/console_widget.py Outdated Show resolved Hide resolved
qtconsole/console_widget.py Outdated Show resolved Hide resolved
jsbautista and others added 19 commits September 14, 2024 11:40
dalthviz
dalthviz reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the latest changes @jsbautista ! Left some new comments/suggestions related with the method that gathers the different actions with shortcuts over a dictionary. Also, it could be nice to add a GIF or a command/flag/config file over the PR description to show an example of how changing the shortcuts could be done using the work being done here.

qtconsole/util.py Outdated Show resolved Hide resolved
qtconsole/qtconsoleapp.py Outdated Show resolved Hide resolved
qtconsole/qtconsoleapp.py Outdated Show resolved Hide resolved
qtconsole/qtconsoleapp.py Outdated Show resolved Hide resolved
qtconsole/qtconsoleapp.py Outdated Show resolved Hide resolved
@dalthviz dalthviz self-requested a review November 15, 2024 19:34
@dalthviz dalthviz self-assigned this Jan 29, 2025
@dalthviz
Copy link
Collaborator

Note: Merging this should be done via a squash merge (there are quite a number of commits with duplicated/not very informative messages)

@dalthviz dalthviz changed the title [WIP] PR: Changes for handling Shortcuts with traitlets in consoleWidget PR: Changes for handling Shortcuts with traitlets in consoleWidget Jan 29, 2025
@dalthviz dalthviz changed the title PR: Changes for handling Shortcuts with traitlets in consoleWidget PR: Changes for handling/customizing shortcuts via traitlet variables and a coverage upload fix Jan 29, 2025
@dalthviz dalthviz requested a review from ccordoba12 January 29, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalthviz dalthviz Awaiting requested review from dalthviz

@ccordoba12 ccordoba12 Awaiting requested review from ccordoba12

Assignees

@dalthviz dalthviz

@jsbautista jsbautista

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsbautista @dalthviz