Skip to content

Commit

Permalink
Merge pull request kubernetes-sigs#1241 from enxebre/log-key
Browse files Browse the repository at this point in the history
 🌱 Use lowercase space separated keys
  • Loading branch information
k8s-ci-robot authored Nov 6, 2020
2 parents a156834 + c6a2a71 commit 8d01076
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion alias.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ var (
// LoggerFrom returns a logger with predefined values from a context.Context.
// The logger, when used with controllers, can be expected to contain basic information about the object
// that's being reconciled like:
// - `reconcilerGroup` and `reconcilerKind` coming from the For(...) object passed in when building a controller.
// - `reconciler group` and `reconciler kind` coming from the For(...) object passed in when building a controller.
// - `name` and `namespace` injected from the reconciliation request.
//
// This is meant to be used with the context supplied in a struct that satisfies the Reconciler interface.
Expand Down
2 changes: 1 addition & 1 deletion pkg/builder/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ func (blder *Builder) doController(r reconcile.Reconciler) error {
if ctrlOptions.Log == nil {
ctrlOptions.Log = blder.mgr.GetLogger()
}
ctrlOptions.Log = ctrlOptions.Log.WithValues("reconcilerGroup", gvk.Group, "reconcilerKind", gvk.Kind)
ctrlOptions.Log = ctrlOptions.Log.WithValues("reconciler group", gvk.Group, "reconciler kind", gvk.Kind)

// Build the controller and return.
blder.ctrl, err = newController(blder.getControllerName(gvk), blder.mgr, ctrlOptions)
Expand Down

0 comments on commit 8d01076

Please sign in to comment.