Fixes for HTTP/3 CONNECT proxy #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the first frame in control streams are required to be SETTINGS frame, so 'loop0' should be called only at the beginning. Without this fix, clients won't be able to open second stream in the same connection, since any non-SETTINGS frame in control stream will abort the whole connection (PRIORITY_UPDATE frame in my case).
The CONNECT method only requires ":method" and ":authority" in headers[1]. [1]: https://www.rfc-editor.org/rfc/rfc9114.html#section-4.4-3
Owner
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding HTTP/3 support to hprox, and find that CONNECT proxy is not (yet) supported. After some investigation and tracing, I find two blocking issues. This pull request contains fixes to make CONNECT proxy working with HTTP/3.
The client I'm using to test is the builtin QUIC Proxy implementation in Chrome 112 (it supports
h3protocol).There is still a minor issue thatconduitpipes in my implementation is not closed even both client and server closed streams (the same is not happening with HTTP/2), I will try to figure it out why, and possibly open another pull request.EDIT: opened PR kazu-yamamoto/quic#54