return redis list objects too, converted into json list#749
Open
sseide wants to merge 1 commit intokelseyhightower:masterfrom
Open
return redis list objects too, converted into json list#749sseide wants to merge 1 commit intokelseyhightower:masterfrom
sseide wants to merge 1 commit intokelseyhightower:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently redis objects of type "list" are ignored.
This patch converts redis lists into json lists (strings) to be available within the templating engine via "jsonArray (getv (...)". As other backends like consul does not support other types than strings this can be used to have interchangeable backends while using native datatype support of the backend.
As this is my very first try in GO there may things be done in a better way probably...
p.s. reformatting was done automatically by IntelliJ or some other tool, dont now...