Repository navigation
Document 1Password connect links - #770
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Also fixes the expiry and web view details against 1Password's spec. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
masnwilliams
left a comment
There was a problem hiding this comment.
accurate, and it matches the API behavior and 1Password's connect-link guidance. one fix before merge, plus a few optional suggestions.
fix: checklist step 1 says to offer the connect link "to users who don't have 1Password yet", but the new section says to present it for everyone, with action.url as the "I already have 1Password" option. a reader who stops at the checklist will build the wrong UI. suggestion inline.
optional, take or leave:
- the TypeScript and Python samples (
// Present account.action.url…) and the sequence diagram (present oauth url) still mention only the one link. naming both would help people who copy the samples. - expiry is now covered in two places: "the authorization url expires after a short time…" above, and "both links expire at the same time" in the new section. you could fold the second into the first.
- "a recovery link has no
connect_url" might read more naturally in the recovery section. it currently says to present itsurl"as you did when connecting", which now means two links. - 1Password still labels connect links as partner preview ("details may change"). a short note would set expectations, since the comparison table calls this path generally available.
- nit: "unlike
action.url, it also works for…" can drop the "also".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks Mason! Took all of them in 0c5eeee: your checklist wording, both links named in the samples and diagram, expiry folded into the paragraph above, the recovery note moved to the recovery section, a partner preview note, and dropped the "also". |
masnwilliams
left a comment
There was a problem hiding this comment.
thanks, all addressed. lgtm.
Summary
Documents
action.connect_urlfrom kernel/kernel#5612 on the 1Password page:action.urlas "I already have 1Password", opening it as a page load or with the system URL handler, and that either link settles the authorization, both expire together, and recovery links have none.pending_authorizationrow and step 1 of the KERNEL-managed checklist mention the connect link.Merge after kernel/kernel#5612 is deployed to production.
🤖 Generated with Claude Code
Note
Low Risk
Documentation-only updates to the 1Password integration guide; no runtime or API code changes.
Overview
Documents
action.connect_urlon the 1Password brokered-approval page so integrators can support users with and without 1Password installed.The KERNEL-managed OAuth checklist, sequence diagram, code samples, and
pending_authorizationstatus row now tell apps to presentconnect_urlalongsideaction.url. Expiration text notes both links refresh together on upsert.A new "Offer a connect link" section explains mobile app vs browser/sign-up behavior, pairing
action.urlas an "already have 1Password" option, openingconnect_urlvia the system URL handler on phones, and constraints (no prefetch, first approval wins, partner preview). Recovery is clarified: recovery OAuth actions exposeurlonly, notconnect_url.Reviewed by Cursor Bugbot for commit 0c5eeee. Bugbot is set up for automated code reviews on this repo. Configure here.