This repository has been archived by the owner on Jan 4, 2022. It is now read-only.
kubeadm join: fix TLS on Kubernetes >=1.9 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d98f4a to
7221e73
Compare
|
Can you provide a description? |
kubeadm got a new option in version 1.8: --discovery-token-unsafe-skip-ca-verification See: kubernetes/kubernetes#49520 Since version 1.9, it became mandatory to either use it to skip verification, or to use --discovery-token-ca-cert-hash=... See: kubernetes/kubernetes#55468 Since kube-spawn is a developer tool used on one physical machine, use the former.
7221e73 to
0edaa40
Compare
|
@blixtra updated. |
dongsupark
approved these changes
Nov 26, 2017
| // It is mandatory since Kubernetes 1.9 | ||
| // See: https://github.com/kubernetes/kubernetes/pull/55468 | ||
| // Test is !<1.8 instead of >=1.8 in order to handle non-semver version 'latest' | ||
| if !utils.CheckVersionConstraint(cfg.KubernetesVersion, "<1.8") { |
There was a problem hiding this comment.
FYI, similar version checks are done in pkg/config/defaults.go, either if cfg.DevCluster || utils.CheckVersionConstraint(cfg.KubernetesVersion, ">=1.8.0") or if !cfg.DevCluster && utils.CheckVersionConstraint(cfg.KubernetesVersion, "<1.8.0"). In this file the check is now used a little differently. Basically this pattern is kind of error-prone, so I think we should be somehow consistent. We could make a helper to simplify it in another PR.
|
Thanks for the review & test! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubeadm got a new option in version 1.8:
--discovery-token-unsafe-skip-ca-verificationSee: kubernetes/kubernetes#49520
Since version 1.9, it became mandatory to either use it to skip verification, or to use
--discovery-token-ca-cert-hash=...See: kubernetes/kubernetes#55468
Since kube-spawn is a developer tool used on one physical machine, use the former.