Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap mouse forward and back buttons in UWP app #216

Merged
merged 4 commits into from
Dec 4, 2021

Conversation

Jaifroid
Copy link
Member

@Jaifroid Jaifroid commented Dec 4, 2021

This PR fixes #214. It is only needed in the UWP app because it is handled natively by browsers and by PWAs. Also by Chromium, therefore by Electron and (although I haven't yet tested it) by NWJS.

@Jaifroid
Copy link
Member Author

Jaifroid commented Dec 4, 2021

@washere Please see the test package release for #214 (Mouse back/forward buttons) here:

https://github.com/kiwix/kiwix-js-windows/releases/download/v1.8.12-dev/KiwixWebApp_1.8.12.0_AnyCPU.appxbundle

Please note this test release does not contain the other fix we are testing, as it is built on master and the #215 hasn't been merged yet. Please uninstall the UWP app before installing this version, to be sure you're starting with a clean slate.

I haven't tested this on a hardware mouse. But it works with the X-mouse utility, which simulates the relevant buttons. Please let me know if it works with your hardware mouse.

@Jaifroid Jaifroid added fixed Fixed, awaiting publication in new apps waiting for feedback and removed fixed Fixed, awaiting publication in new apps labels Dec 4, 2021
@Jaifroid Jaifroid added this to the Release 1.8.2 milestone Dec 4, 2021
@Jaifroid
Copy link
Member Author

Jaifroid commented Dec 4, 2021

I have to merge this in order to test if it works in Service Worker mode. Changes can still be made.

@Jaifroid Jaifroid merged commit 93df44c into master Dec 4, 2021
@Jaifroid
Copy link
Member Author

Jaifroid commented Dec 4, 2021

Appears to be working in Service Worker mode.

@Jaifroid Jaifroid deleted the Trap-mouse-forward-and-back-buttons branch December 4, 2021 17:51
Jaifroid added a commit that referenced this pull request Apr 24, 2022
Jaifroid added a commit that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse Buttons BACK & FORWARD Functions Do Not Work.
1 participant