fix: add default for awsRegistryId

knechtionscoding · Apr 5, 2023 · 97f2812 · 97f2812
1 parent 715b91c
commit 97f2812
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/charts/ecr-cleanup/Chart.yaml b/charts/ecr-cleanup/Chart.yaml
@@ -20,10 +20,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.2.4
+version: 0.2.5
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.2.4"
+appVersion: "0.2.5"
diff --git a/charts/ecr-cleanup/README.md b/charts/ecr-cleanup/README.md
@@ -6,13 +6,13 @@ Deploys a job that cleans up an ECR repo based on the following rules.
 3. Has the container been tagged with the word `keep`
 4. Is the container the only tag in the ECR repository
 
-![Version: 0.2.4](https://img.shields.io/badge/Version-0.2.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.2.4](https://img.shields.io/badge/AppVersion-0.2.4-informational?style=flat-square)
+![Version: 0.2.5](https://img.shields.io/badge/Version-0.2.5-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.2.5](https://img.shields.io/badge/AppVersion-0.2.5-informational?style=flat-square)
 
 ## Values
 
 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
-| awsRegistryId | string | `nil` | ECR Registry ID to override picking the default |
+| awsRegistryId | string | `""` | ECR Registry ID to override picking the default |
 | fullnameOverride | string | `""` | Override fullname |
 | image.pullPolicy | string | `"IfNotPresent"` | Pull Policy for images in cronjob |
 | image.registry | string | `"ghcr.io"` | Image Registry |

diff --git a/charts/ecr-cleanup/values.yaml b/charts/ecr-cleanup/values.yaml
@@ -14,7 +14,7 @@ image:
   tag: ""
 
 # -- ECR Registry ID to override picking the default
-awsRegistryId:
+awsRegistryId: ""
 
 # -- List of imagePullSecrets to use when getting images
 imagePullSecrets: []