Skip to content

Commit

Permalink
fix: extraENVs should be an array not object
Browse files Browse the repository at this point in the history
  • Loading branch information
knechtionscoding committed Apr 10, 2023
1 parent 21132c6 commit d9f06bb
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions charts/ecr-cleanup/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.3.0
version: 0.3.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "0.3.0"
appVersion: "0.3.1"
4 changes: 2 additions & 2 deletions charts/ecr-cleanup/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Deploys a job that cleans up an ECR repo based on the following rules.
3. Has the container been tagged with the word `keep`
4. Is the container the only tag in the ECR repository

![Version: 0.3.0](https://img.shields.io/badge/Version-0.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.3.0](https://img.shields.io/badge/AppVersion-0.3.0-informational?style=flat-square)
![Version: 0.3.1](https://img.shields.io/badge/Version-0.3.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.3.1](https://img.shields.io/badge/AppVersion-0.3.1-informational?style=flat-square)

## Values

Expand All @@ -15,7 +15,7 @@ Deploys a job that cleans up an ECR repo based on the following rules.
| awsRegistryId | string | `""` | ECR Registry ID to override picking the default |
| command | list | `["/code/main.py"]` | Command being run by the cronjob |
| dryRun | bool | `false` | Should the tool run in dryrun |
| extraEnvs | object | `{}` | |
| extraEnvs | list | `[]` | |
| fullnameOverride | string | `""` | Override fullname |
| image.pullPolicy | string | `"IfNotPresent"` | Pull Policy for images in cronjob |
| image.registry | string | `"ghcr.io"` | Image Registry |
Expand Down
2 changes: 1 addition & 1 deletion charts/ecr-cleanup/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"extraEnvs": {
"type": [
"object",
"array",
"null"
]
},
Expand Down
2 changes: 1 addition & 1 deletion charts/ecr-cleanup/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,4 @@ resources:
# memory: 128Mi

## -- ENV variables to pass to cronjob
extraEnvs: {}
extraEnvs: []

0 comments on commit d9f06bb

Please sign in to comment.