Merged
Conversation
Removing deprecated stuff
Kool cloud - new subcommand + documentation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
- Coverage 79.34% 74.62% -4.72%
==========================================
Files 72 75 +3
Lines 2702 2901 +199
==========================================
+ Hits 2144 2165 +21
- Misses 499 674 +175
- Partials 59 62 +3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Adding new `kool deploy setup` command + config validator + create interactive
dbpolito
reviewed
Dec 28, 2022
| # Applications usually will require a special image built for deployment. | ||
| build: Dockerfile | ||
|
|
||
| # Tells Kool Cloud that this service is accessible through the deployment URL. |
Member
There was a problem hiding this comment.
size of container and daemons are missing, no mention of variables...
dbpolito
reviewed
Dec 28, 2022
| # The Deploy API will get the contents of this file and make all of them available | ||
| # as true environment variables for the container. You can check them in your deployed | ||
| # container via kool cloud exec env (assuming you have env available). | ||
| environment: kool.deploy.env |
Member
There was a problem hiding this comment.
i think we need to fix this before launch environment and env... it's very confusing...
Comment on lines
+31
to
+35
| * [kool cloud deploy](kool_cloud_deploy) - Deploy a local application to a Kool Cloud environment | ||
| * [kool cloud destroy](kool_cloud_destroy) - Destroy an environment deployed to Kool Cloud | ||
| * [kool cloud exec](kool_cloud_exec) - Execute a command inside a running service container deployed to Kool Cloud | ||
| * [kool cloud logs](kool_cloud_logs) - See the logs of running service container deployed to Kool Cloud | ||
| * [kool cloud setup](kool_cloud_setup) - Set up local configuration files for deployment |
Contributor
There was a problem hiding this comment.
I guess these doc files are missing
dbpolito
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preparing
koolv2.0.kool cloudsubcommand umbrella.kool deploy setupcommand.kool createbecomes interactive when no arguments are supplied.