Skip to content

🌱 Drop unnecessary etcd call in KCP#13330

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
fabriziopandini:kcp-drop-unecessary-etcd-call
Feb 12, 2026
Merged

🌱 Drop unnecessary etcd call in KCP#13330
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
fabriziopandini:kcp-drop-unecessary-etcd-call

Conversation

@fabriziopandini
Copy link
Copy Markdown
Member

What this PR does / why we need it:
While checking if remediation is possible, KCP performs an etcd call to read members, but we already have members list in the controlPlane object. So dropping the call.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@fabriziopandini fabriziopandini added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Feb 11, 2026
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 11, 2026
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 11, 2026
Comment thread controlplane/kubeadm/internal/controllers/remediation.go Outdated
Comment thread controlplane/kubeadm/internal/controllers/remediation_test.go
@fabriziopandini fabriziopandini force-pushed the kcp-drop-unecessary-etcd-call branch from c69f4d1 to da04af8 Compare February 12, 2026 12:12
@sbueringer
Copy link
Copy Markdown
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 52d0de496af4778604f8a193e330e6151b079bf3

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2026
@k8s-ci-robot k8s-ci-robot merged commit eaf086b into kubernetes-sigs:main Feb 12, 2026
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Feb 12, 2026
@fabriziopandini fabriziopandini deleted the kcp-drop-unecessary-etcd-call branch April 10, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants