Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get port used #475

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix get port used #475

merged 1 commit into from
Apr 12, 2023

Conversation

ikaven1024
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

When I create two clusters on my side:

kwokctl create cluster --runtime=binary --kube-apiserver-binary ~/bin/kube-apiserver --kube-controller-manager-binary ~/bin/kube-controller-manager --kube-scheduler-binary ~/bin/kube-scheduler --kwok-controller-binary /opt/homebrew/bin/kwok --etcd-binary ~/bin/etcd --name cluster1
kwokctl create cluster --runtime=binary --kube-apiserver-binary ~/bin/kube-apiserver --kube-controller-manager-binary ~/bin/kube-controller-manager --kube-scheduler-binary ~/bin/kube-scheduler --kwok-controller-binary /opt/homebrew/bin/kwok --etcd-binary ~/bin/etcd --name cluster2

I found etcds in both cluster are using 32766 port.

Etcd is listening on 'localhost:32766', while I run below code returns no error:

listener, err = net.Listen("tcp", ":32766")

So I change the UnusedPort function in this PR to fix this problem.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 11, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 11, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ikaven1024 / name: yjh (8c1beca)

@netlify
Copy link

netlify bot commented Apr 11, 2023

Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit d34b52a
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/643633b1f5a0670008f1f2b9
😎 Deploy Preview https://deploy-preview-475--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ikaven1024. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 11, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 11, 2023
@wzshiming
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2023
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ikaven1024, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 803f599 into kubernetes-sigs:main Apr 12, 2023
wzshiming added a commit that referenced this pull request Apr 17, 2023
…upstream-release-0.1

Automated cherry pick of #475: fix get port used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants