Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid newline "\n" in the error to break log msg to 2 lines #49826

Merged
merged 1 commit into from
Oct 3, 2017
Merged

avoid newline "\n" in the error to break log msg to 2 lines #49826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
avoid newline "\n" in the error to break log msg to 2 lines
  • Loading branch information
@dixudx
dixudx committed Jul 29, 2017
commit 4bef8af68574a7cdc3351d74d5e9435b2b7022cc
5 changes: 2 additions & 3 deletions pkg/util/goroutinemap/exponentialbackoff/exponential_backoff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,8 @@ func (expBackoff *ExponentialBackoff) Update(err *error) {
expBackoff.lastErrorTime = time.Now()
}

func (expBackoff *ExponentialBackoff) GenerateNoRetriesPermittedMsg(
operationName string) string {
return fmt.Sprintf("Operation for %q failed. No retries permitted until %v (durationBeforeRetry %v). Error: %v",
func (expBackoff *ExponentialBackoff) GenerateNoRetriesPermittedMsg(operationName string) string {
return fmt.Sprintf("Operation for %q failed. No retries permitted until %v (durationBeforeRetry %v). Error: %q",
operationName,
expBackoff.lastErrorTime.Add(expBackoff.durationBeforeRetry),
expBackoff.durationBeforeRetry,
Expand Down