Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up cvm-master jobs #4898

Merged
merged 3 commits into from
Oct 6, 2017
Merged

Clean up cvm-master jobs #4898

merged 3 commits into from
Oct 6, 2017

Conversation

krzyzacy
Copy link
Member

@krzyzacy krzyzacy commented Oct 5, 2017 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 5, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2017
@krzyzacy krzyzacy removed the request for review from michelle192837 October 5, 2017 22:18
@krzyzacy
Copy link
Member Author

krzyzacy commented Oct 5, 2017

/assign @BenTheElder @abgworrall

wanna double check here?

  • For all master jobs has a gci-* alternative, simply deleted the cvm version
  • For all mater jobs does not have a gci-* alternative, s/container_vm/gci/
  • For most of testgrid sig-* dashboards, refer to gci-* version of job instead

TODO: we probably can remove all the --gcp-node-image=gci lines as that should be default now. I removed them from some canary jobs see if they still work well.

@krzyzacy
Copy link
Member Author

krzyzacy commented Oct 5, 2017

fixes #4883

@BenTheElder
Copy link
Member

🗑️
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [BenTheElder,krzyzacy]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@krzyzacy
Copy link
Member Author

krzyzacy commented Oct 6, 2017

/hold
:-( bad rebase

@BenTheElder
Copy link
Member

Hmm is LGTM cancel after push a munger? @cjwagner

@0xmichalis
Copy link
Contributor

Hmm is LGTM cancel after push a munger? @cjwagner

Yes. There is #3821 that moves it in prow.

@krzyzacy
Copy link
Member Author

krzyzacy commented Oct 6, 2017

/hold cancel
okay sorted out

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2017
@k8s-ci-robot k8s-ci-robot merged commit 831d39d into kubernetes:master Oct 6, 2017
@k8s-ci-robot
Copy link
Contributor

@krzyzacy: I updated Prow config for you!

In response to this:

/hold

ref kubernetes/kubernetes#53350

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krzyzacy
Copy link
Member Author

krzyzacy commented Oct 6, 2017

(@k8s-ci-robot that's fast...)

@krzyzacy krzyzacy deleted the cvm branch October 6, 2017 21:50
@BenTheElder
Copy link
Member

Hmm we should probably try to get #3821 sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BenTheElder BenTheElder

@abgworrall abgworrall

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@krzyzacy @BenTheElder @k8s-github-robot @0xmichalis @k8s-ci-robot @abgworrall