Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: ignore sign bit when all value are negative #2912

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thinh2
Copy link

@thinh2 thinh2 commented Sep 19, 2024

Implementation for #2714 .

Copy link

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@thinh2 thinh2 changed the title ignore sign bit when all value are negative feat: ignore sign bit when all value are negative Sep 19, 2024
@github-actions github-actions bot added the enhancement New feature or request label Sep 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 65.51724% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (3f935d5) to head (214a8b7).

Files with missing lines Patch % Lines
...t/lance-encoding/src/encodings/physical/bitpack.rs 65.38% 9 Missing ⚠️
rust/lance-encoding/src/encodings/physical.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2912      +/-   ##
==========================================
- Coverage   77.83%   77.83%   -0.01%     
==========================================
  Files         231      231              
  Lines       70199    70219      +20     
  Branches    70199    70219      +20     
==========================================
+ Hits        54641    54656      +15     
+ Misses      12691    12679      -12     
- Partials     2867     2884      +17     
Flag Coverage Δ
unittests 77.83% <65.51%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward to me. @albertlockett any thoughts?

@thinh2 thinh2 changed the title feat: ignore sign bit when all value are negative draft: ignore sign bit when all value are negative Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants