Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fix TestResponseAssert docblock #51942

Merged
merged 1 commit into from
Jun 28, 2024
Merged

[11.x] Fix TestResponseAssert docblock #51942

merged 1 commit into from
Jun 28, 2024

Conversation

seriquynh
Copy link
Contributor

  • $method and $args do not match $name and $arguments.
  • Assert::* methods return void and throw \PHPUnit\Framework\ExpectationFailedException, so do __call and __callStatic.
  • It's \PHPUnit\Framework\ExpectationFailedException, not \ExpectationFailedException.

@taylorotwell taylorotwell merged commit c307abc into laravel:11.x Jun 28, 2024
30 checks passed
@renovate renovate bot mentioned this pull request Sep 13, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seriquynh @driesvints @taylorotwell