Repository navigation
chore(deps): bump github.com/spf13/cobra from 1.9.1 to 1.10.2 - #725
Conversation
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.9.1 to 1.10.2. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.9.1...v1.10.2) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-version: 1.10.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Rebased this bump onto current |
The cobra branch is 36 commits behind main, and `dev-server start` requires --access-token even for an empty local boot. Document both, and add the dry-run report as an example of the output contract. Co-authored-by: Ramon Niebla <nieblara@users.noreply.github.com>
Dependency verification: SAFE TO MERGERisk tier medium (cli-surface) · ecosystems: gomod · head Every required check ran and passed. No decision is necessary. Updates
What the verifier checked
Already failing on
|
| Check | Kind | Base | PR | Outcome |
|---|---|---|---|---|
ldcli help <cmd> runs the help function with the root context |
discriminating | fail | pass | proven (fails on base, passes on PR) |
Impact review
cobra v1.9.1 to v1.10.2 sets the target command context in the built-in help command, fixes the 'Additional help topics' typo in the default usage function, makes the padding and template variables constants, and follows pflag in renaming ParseErrorsWhitelist to ParseErrorsAllowlist (pflag 1.0.9 keeps the old name). ldcli builds its whole CLI on cobra (cmd/). The context change reaches ldcli help <cmd> through the help wrapper in cmd/root.go. Help output is identical for all 416 commands, because ldcli sets its own usage template.
- github.com/spf13/cobra v1.9.1..v1.10.2: 1.10.0: flow the context to the command in the help command (#2241), a customizable default ShellCompDirective (#2238), pflag 1.0.8 with ParseErrorsAllowlist. 1.10.1: pflag 1.0.9 restores the deprecated ParseErrorsWhitelist. 1.10.2: yaml moves from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3 (doc generation only), vars become consts, and the 'topcis' typo is fixed. (source)
- Used in:
cmd/root.go,cmd/config/config.go,cmd/whoami/whoami.go,cmd/resources/resource_cmds.go - Upstream behavior changes that reach ldcli: yes
- Note: The help-context change (#2241) reaches
ldcli help <cmd>: the root help wrapper in cmd/root.go now gets the root context. No ldcli help function reads the context today, so users see no change. The generated check proves the change on the real command tree. (Flow context to command in SetHelpFunc spf13/cobra#2241, cmd/root.go) - Note: ldcli does not use FParseErrWhitelist, ParseErrorsWhitelist, or the cobra doc generator, so the pflag rename and the yaml module move do not reach it. transitive-changes reports no other compiled module change. (state/checks/transitive-changes)
- Note: The typo fix is in defaultUsageFunc, which ldcli does not use because it sets usage templates. cli-help-diff shows identical help for 416 commands. (state/checks/cli-help-diff)
Check details
pr-state
- Branch is 51 commit(s) behind
main. The checks ran on the PR merged into the currentmain.
ci-status
- CI results are for the PR head
b1131b7as pushed, which may be behind the base branch.
upstream-changes
github.com/spf13/cobrav1.9.1 → v1.10.2: spf13/cobra, 26 commits, 18 files, notes: release notes, full range, mentions: breaking (1), security (1), deprecation (3)
transitive-changes
- gomod (modules compiled into ldcli): 1 changed, 0 added, 0 removed
github.com/spf13/cobrav1.9.1 → v1.10.2 (minor)
license-changes
github.com/spf13/cobra@v1.10.2: Apache-2.0
go-generate-drift
Files rewritten by go generate ./... (patch saved as drift.patch next to this check's status):
internal/dev_server/api/server.gen.go | 430 +++++++++++++++-----
1 file changed, 323 insertions(+), 107 deletions(-)
The regenerated code does not compile:
# github.com/launchdarkly/ldcli/internal/dev_server/api
internal/dev_server/api/data_mapping.go:11:5: unknown field Id in struct literal of type Variation
internal/dev_server/api/get_project.go:20:3: unknown field LastSyncedFromSource in struct literal of type ProjectJSONResponse
internal/dev_server/api/patch_project.go:24:3: unknown field LastSyncedFromSource in struct literal of type ProjectJSONResponse
internal/dev_server/api/post_add_project.go:38:3: unknown field LastSyncedFromSource in struct literal of type ProjectJSONResponse
internal/dev_server/api/post_import_project.go:45:21: v.Id undefined (type Variation has no field or method Id)
internal/dev_server/api/post_import_project.go:75:3: unknown field LastSyncedFromSource in struct literal of type ProjectJSONResponse
internal/dev_server/api/server.gen.go:382:16: undefined: runtime.BindQueryParameterWithOptions
internal/dev_server/api/server.gen.go:382:114: undefined: runtime.BindQueryParameterOptions
internal/dev_server/api/server.gen.go:384:30: undefined: runtime.RequiredParameterError
internal/dev_server/api/server.gen.go:395:16: undefined: runtime.BindQueryParameterWithOptions
internal/dev_server/api/server.gen.go:395:16: too many errors
govulncheck
- Still reachable on the PR: GO-2026-5320 (github.com/yuin/goldmark, fixed in v1.7.17), GO-2026-5970 (golang.org/x/text, fixed in v0.39.0)
release-snapshot
- Release image not pullable (unauthorized). Fallback: public
goreleaser/goreleaser-cross:v1.24.2(goreleaser/goreleaser-cross@sha256:c4bfde12925cd9e23faae3e35…) with sha256-pinned musl.cc toolchains at/musl. - dist/ldcli_darwin_amd64_v1/ldcli: Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE>
- dist/ldcli_darwin_arm64_v8.0/ldcli: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE>
- dist/ldcli_linux_386_sse2/ldcli: ELF 32-bit LSB executable, Intel 80386
- dist/ldcli_linux_amd64_v1/ldcli: ELF 64-bit LSB executable, x86-64
- dist/ldcli_linux_arm64_v8.0/ldcli: ELF 64-bit LSB executable, ARM aarch64
- dist/ldcli_windows_386_sse2/ldcli.exe: PE32 executable (console) Intel 80386, for MS Windows
- dist/ldcli_windows_amd64_v1/ldcli.exe: PE32+ executable (console) x86-64, for MS Windows
- dist/ldcli_windows_arm64_v8.0/ldcli.exe: PE32+ executable (console) Aarch64, for MS Windows
- Fidelity gap: the public image plus musl.cc replace the LaunchDarkly image, which can have extras that this build does not have.
- Fidelity gap: the binaries are built, but not executed.
- Fidelity gap:
goreleaser builddoes not run thedockers,docker_manifests, orbrewssteps.
binary-smoke
ldcli --version: ldcli version dev- dev-server served /ui/ (1160 KB) and /dev/projects (
[])
generated: help-command-flows-context
ldcli help flags under ExecuteContext: help-context: root
Generated by scripts/dependency-pr/verify.sh (profile full) at 2026-10-06T21:57:05Z. The verifier does not approve or merge.
Bumps github.com/spf13/cobra from 1.9.1 to 1.10.2.
Release notes
Sourced from github.com/spf13/cobra's releases.
... (truncated)
Commits
88b30abchore: Migrate from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3 (#2336)346d408fix: actions/setup-go v6 (#2337)fc81d20refactor: change minUsagePadding from var to const (#2325)117698arefactor: replace several vars with consts (#2328)e2dd29dAdd documentation for repeated flags functionality (#2316)0629892Fix linter (#2327)7da941cchore: Bump pflag to v1.0.9 (#2305)51d6751Bump pflag to 1.0.8 (#2303)3f3b818Update README.md with new logodcaf42eAdd Periscope to the list of projects using Cobra (#2299)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Overview
Bumps
github.com/spf13/cobrafrom 1.9.1 to 1.10.2 ingo.mod, with matching checksum updates ingo.sum. There are no application source changes—only the CLI framework dependency version moves forward (including upstream’s newerpflagalignment and yaml module path cleanup inside cobra).This should be behavior-neutral for
ldcliunless you rely on obscure cobra/pflag edge cases; existing directspf13/pflagv1.0.10 already satisfies the compatibility notes from the 1.10.x line.Reviewed by Cursor Bugbot for commit 123a2ec. Bugbot is set up for automated code reviews on this repo. Configure here.