Skip to content

chore(deps): bump github.com/spf13/cobra from 1.9.1 to 1.10.2 - #725

Merged
ld-ahartmann merged 2 commits into
mainfrom
dependabot/go_modules/github.com/spf13/cobra-1.10.2
Oct 6, 2026
Merged

ld-ahartmann merged 2 commits into
mainfrom
dependabot/go_modules/github.com/spf13/cobra-1.10.2

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 23, 2026 •

Copy link
Copy Markdown
Contributor

Bumps github.com/spf13/cobra from 1.9.1 to 1.10.2.

Release notes

Sourced from github.com/spf13/cobra's releases.

v1.10.2

🔧 Dependencies

  • chore: Migrate from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3 by @​dims in spf13/cobra#2336 - the gopkg.in/yaml.v3 package has been deprecated for some time: this should significantly cleanup dependency/supply-chains for consumers of spf13/cobra

📈 CI/CD

🔥✍🏼 Docs

🍂 Refactors

🤗 New Contributors

Full Changelog: spf13/cobra@v1.10.1...v1.10.2

Thank you to our amazing contributors!!!!! 🐍 🚀

v1.10.1

🐛 Fix

v1.0.9 of pflags brought back ParseErrorsWhitelist and marked it as deprecated

Full Changelog: spf13/cobra@v1.10.0...v1.10.1

v1.10.0

What's Changed

🚨 Attention!

This version of pflag carried a breaking change: it renamed ParseErrorsWhitelist to ParseErrorsAllowlist which can break builds if both pflag and cobra are dependencies in your project.

  • If you use both pflag and cobra, upgrade pflagto 1.0.8 andcobrato1.10.0`
  • or use the newer, fixed version of pflag v1.0.9 which keeps the deprecated ParseErrorsWhitelist

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note

Overview
Bumps github.com/spf13/cobra from 1.9.1 to 1.10.2 in go.mod, with matching checksum updates in go.sum. There are no application source changes—only the CLI framework dependency version moves forward (including upstream’s newer pflag alignment and yaml module path cleanup inside cobra).

This should be behavior-neutral for ldcli unless you rely on obscure cobra/pflag edge cases; existing direct spf13/pflag v1.0.10 already satisfies the compatibility notes from the 1.10.x line.

Reviewed by Cursor Bugbot for commit 123a2ec. Bugbot is set up for automated code reviews on this repo. Configure here.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.9.1 to 1.10.2.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.9.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@cursor

cursor Bot commented Sep 18, 2026

Copy link
Copy Markdown

Rebased this bump onto current main as #807 (github.com/spf13/cobra v1.9.1 → v1.10.2; pflag stays at v1.0.10). This original branch is 36 commits behind and auto-rebase is disabled, so the replacement PR is the mergeable version.

cursor Bot pushed a commit that referenced this pull request Sep 18, 2026
The cobra branch is 36 commits behind main, and `dev-server start`
requires --access-token even for an empty local boot. Document both,
and add the dry-run report as an example of the output contract.

Co-authored-by: Ramon Niebla <nieblara@users.noreply.github.com>
@cursor

cursor Bot commented Oct 6, 2026

Copy link
Copy Markdown

Dependency verification: SAFE TO MERGE

Risk tier medium (cli-surface) · ecosystems: gomod · head b1131b7 tested as merged into main @ 9197f92

Every required check ran and passed. No decision is necessary.

Updates

Package From To Change Ecosystem Tier
github.com/spf13/cobra v1.9.1 v1.10.2 minor gomod medium

What the verifier checked

Check Result Summary
PR merges cleanly and changes only dependency files pass Merges cleanly into main; only dependency manifests changed
CI results on the PR head pass All 9 CI checks green on PR head b1131b7
No dependency goes to a lower version than base pass No downgrades
Upstream release notes and diff of each direct update pass (note) Upstream notes cover the full range for 1 of 1 direct update(s); notes mention: breaking (1), deprecation (1), security (1). The impact review must cover them
Transitive dependency changes (new, removed, major, install scripts) pass (note) gomod: 1 changed (0 major), 0 added, 0 removed
Licenses of new and changed dependencies pass All 1 added or changed dependencies use a license in the policy, with no license change
go mod tidy makes no change to go.mod or go.sum pass go.mod/go.sum are tidy
go and toolchain directives (unchanged, or the new version is supported) pass go 1.25 (unchanged)
go build and go vet pass go build ./... and go vet ./... succeed
go test ./... (isolated environment) pass 51 packages pass
go generate makes no change, and the generated code builds fails on base too go generate rewrites 1 file(s) and the regenerated code does not compile
govulncheck: no new reachable vulnerabilities pass No new reachable vulnerabilities; still reachable: GO-2026-5320, GO-2026-5970
All release targets cross-compile in goreleaser-cross (CGO) pass All 8 release targets build in goreleaser-cross (the public image with musl.cc toolchains, not the release image)
golangci-lint (pre-commit configuration) pass golangci-lint clean (v1.63.4)
Binary smoke test: --version, help for all commands, dev-server serves the UI and API pass --version, --help for 416 commands, dev-server UI and API all OK
CLI help output is the same as on base pass Help output identical for 416 commands

Already failing on main (not caused by this PR)

  • go generate makes no change, and the generated code builds: go generate rewrites 1 file(s) and the regenerated code does not compile

Generated checks

A generated check counts only when it fails on the old version and passes on the new one. 1 of 1 proven.

Check Kind Base PR Outcome
ldcli help <cmd> runs the help function with the root context discriminating fail pass proven (fails on base, passes on PR)

Impact review

cobra v1.9.1 to v1.10.2 sets the target command context in the built-in help command, fixes the 'Additional help topics' typo in the default usage function, makes the padding and template variables constants, and follows pflag in renaming ParseErrorsWhitelist to ParseErrorsAllowlist (pflag 1.0.9 keeps the old name). ldcli builds its whole CLI on cobra (cmd/). The context change reaches ldcli help <cmd> through the help wrapper in cmd/root.go. Help output is identical for all 416 commands, because ldcli sets its own usage template.

  • github.com/spf13/cobra v1.9.1..v1.10.2: 1.10.0: flow the context to the command in the help command (#2241), a customizable default ShellCompDirective (#2238), pflag 1.0.8 with ParseErrorsAllowlist. 1.10.1: pflag 1.0.9 restores the deprecated ParseErrorsWhitelist. 1.10.2: yaml moves from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3 (doc generation only), vars become consts, and the 'topcis' typo is fixed. (source)
  • Used in: cmd/root.go, cmd/config/config.go, cmd/whoami/whoami.go, cmd/resources/resource_cmds.go
  • Upstream behavior changes that reach ldcli: yes
  • Note: The help-context change (#2241) reaches ldcli help <cmd>: the root help wrapper in cmd/root.go now gets the root context. No ldcli help function reads the context today, so users see no change. The generated check proves the change on the real command tree. (Flow context to command in SetHelpFunc spf13/cobra#2241, cmd/root.go)
  • Note: ldcli does not use FParseErrWhitelist, ParseErrorsWhitelist, or the cobra doc generator, so the pflag rename and the yaml module move do not reach it. transitive-changes reports no other compiled module change. (state/checks/transitive-changes)
  • Note: The typo fix is in defaultUsageFunc, which ldcli does not use because it sets usage templates. cli-help-diff shows identical help for 416 commands. (state/checks/cli-help-diff)
Check details

pr-state

  • Branch is 51 commit(s) behind main. The checks ran on the PR merged into the current main.

ci-status

  • CI results are for the PR head b1131b7 as pushed, which may be behind the base branch.

upstream-changes

  • github.com/spf13/cobra v1.9.1 → v1.10.2: spf13/cobra, 26 commits, 18 files, notes: release notes, full range, mentions: breaking (1), security (1), deprecation (3)

transitive-changes

  • gomod (modules compiled into ldcli): 1 changed, 0 added, 0 removed
    • github.com/spf13/cobra v1.9.1 → v1.10.2 (minor)

license-changes

  • github.com/spf13/cobra@v1.10.2: Apache-2.0

go-generate-drift

Files rewritten by go generate ./... (patch saved as drift.patch next to this check's status):

 internal/dev_server/api/server.gen.go | 430 +++++++++++++++-----
 1 file changed, 323 insertions(+), 107 deletions(-)

The regenerated code does not compile:

# github.com/launchdarkly/ldcli/internal/dev_server/api
internal/dev_server/api/data_mapping.go:11:5: unknown field Id in struct literal of type Variation
internal/dev_server/api/get_project.go:20:3: unknown field LastSyncedFromSource in struct literal of type ProjectJSONResponse
internal/dev_server/api/patch_project.go:24:3: unknown field LastSyncedFromSource in struct literal of type ProjectJSONResponse
internal/dev_server/api/post_add_project.go:38:3: unknown field LastSyncedFromSource in struct literal of type ProjectJSONResponse
internal/dev_server/api/post_import_project.go:45:21: v.Id undefined (type Variation has no field or method Id)
internal/dev_server/api/post_import_project.go:75:3: unknown field LastSyncedFromSource in struct literal of type ProjectJSONResponse
internal/dev_server/api/server.gen.go:382:16: undefined: runtime.BindQueryParameterWithOptions
internal/dev_server/api/server.gen.go:382:114: undefined: runtime.BindQueryParameterOptions
internal/dev_server/api/server.gen.go:384:30: undefined: runtime.RequiredParameterError
internal/dev_server/api/server.gen.go:395:16: undefined: runtime.BindQueryParameterWithOptions
internal/dev_server/api/server.gen.go:395:16: too many errors

govulncheck

  • Still reachable on the PR: GO-2026-5320 (github.com/yuin/goldmark, fixed in v1.7.17), GO-2026-5970 (golang.org/x/text, fixed in v0.39.0)

release-snapshot

  • Release image not pullable (unauthorized). Fallback: public goreleaser/goreleaser-cross:v1.24.2 (goreleaser/goreleaser-cross@sha256:c4bfde12925cd9e23faae3e35…) with sha256-pinned musl.cc toolchains at /musl.
  • dist/ldcli_darwin_amd64_v1/ldcli: Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE>
  • dist/ldcli_darwin_arm64_v8.0/ldcli: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE>
  • dist/ldcli_linux_386_sse2/ldcli: ELF 32-bit LSB executable, Intel 80386
  • dist/ldcli_linux_amd64_v1/ldcli: ELF 64-bit LSB executable, x86-64
  • dist/ldcli_linux_arm64_v8.0/ldcli: ELF 64-bit LSB executable, ARM aarch64
  • dist/ldcli_windows_386_sse2/ldcli.exe: PE32 executable (console) Intel 80386, for MS Windows
  • dist/ldcli_windows_amd64_v1/ldcli.exe: PE32+ executable (console) x86-64, for MS Windows
  • dist/ldcli_windows_arm64_v8.0/ldcli.exe: PE32+ executable (console) Aarch64, for MS Windows
  • Fidelity gap: the public image plus musl.cc replace the LaunchDarkly image, which can have extras that this build does not have.
  • Fidelity gap: the binaries are built, but not executed.
  • Fidelity gap: goreleaser build does not run the dockers, docker_manifests, or brews steps.

binary-smoke

  • ldcli --version: ldcli version dev
  • dev-server served /ui/ (1160 KB) and /dev/projects ([])

generated: help-command-flows-context

ldcli help flags under ExecuteContext: help-context: root

Generated by scripts/dependency-pr/verify.sh (profile full) at 2026-10-06T21:57:05Z. The verifier does not approve or merge.

@nieblara
nieblara requested a review from a team as a code owner October 6, 2026 22:52
@ld-ahartmann
ld-ahartmann merged commit a64578d into main Oct 6, 2026
10 checks passed
@ld-ahartmann
ld-ahartmann deleted the dependabot/go_modules/github.com/spf13/cobra-1.10.2 branch October 6, 2026 23:49
cursor Bot pushed a commit that referenced this pull request Oct 20, 2026
The details printed the output of file -b as it was, so text such as
flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE> was outside code, and each post of
#725, #828, #871, #874, and #621 needed a hand edit.

Co-authored-by: rniebla <rniebla@launchdarkly.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants