Dev/nav #21
Closed
Dev/nav #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nubertj
requested changes
Mar 28, 2023
| @@ -55,6 +56,8 @@ class HeadingController { | |||
| PathSegment currentPathSegment_; | |||
| unsigned int lastClosestPointId_ = 0; | |||
| Vector desiredLinearVelocity_; | |||
| // max path deviation from tracked path | |||
| double maxPathDistance_ = 1.0; | |||
There was a problem hiding this comment.
maxPathDeviation_ would be better, similar to your comment
| @@ -35,7 +35,15 @@ void SimplePathTracker::importCurrentPath(const Path& path) { | |||
| if (!isPathAndCurrenStateWithinRadius(path, headingController_->getActiveLookaheadDistance())) { | |||
| std::cout << "WARNING: path imported is more than one lookahead distance away from the current state" << std::endl; | |||
| } | |||
| currentPath_ = path; | |||
| // remove from path segments that have less than two points (they are not valid for pure pursuit) | |||
There was a problem hiding this comment.
this is only ran once in the beginning after importing the path, right?
Otherwise it could maybe be implementted more efficiently...
There was a problem hiding this comment.
what happened before with the pure pursuit with these segments?
| @@ -156,7 +156,9 @@ void updateFromDD(const pure_pursuit_ros::PurePursuitConfig& config, AckermannSt | |||
| param->maxSteeringAngleMagnitude_ = config.max_steering_angle_magnitude_in_deg * kDegToRad; | |||
| param->maxSteeringRateOfChange_ = config.max_steering_rate_of_change_in_deg_per_sec * kDegToRad; | |||
| param->wheelBase_ = config.wheel_base; | |||
| param->maxPathDistance_ = config.max_path_distance; | |||
There was a problem hiding this comment.
having some comments in the config would be nice I assume.
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| # Response | |||
| bool status | |||
|
Closing due to inactivity. Feel free to reopen |
|
yes, I will let @Idate96 decide whether he wants to further follow up on this or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new functionality to: