Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/online path update #7

Merged
merged 3 commits into from
Jan 18, 2021

Conversation

meychr
Copy link
Contributor

@meychr meychr commented Jan 13, 2021

This PR introduces an additional function updateCurrentPath to the SimplePathTracker. It makes it possible to replace a loaded path in the SimplePathTracker with a new one while it is executed.
The path is not validated e.g. if start of new trajectory is reasonably close to loaded one. It might be better to add something along these lines. With the currently used pure pursuit controller, it is not really a problem because the controller reacts quite slowly.

Copy link
Collaborator

@jelavice jelavice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nice thing to have would be a check whether the imported trajectory is close to the current one. E.g. if the distance is more than one lookaheadDistance, one can issue a warning.

@jelavice jelavice merged commit d108e6d into leggedrobotics:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants