Skip to content

chore: upgrade aegir #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
achingbrain merged 21 commits into from
Mar 14, 2023
Merged

chore: upgrade aegir #1566

achingbrain merged 21 commits into from
Mar 14, 2023

Conversation

@maschad
Copy link
Member

@maschad maschad commented Jan 20, 2023

Following the conversation here this will allow us to address #1505

@mpetrunic
Copy link
Member

mpetrunic commented Jan 24, 2023

It appears that it needs to be bumped in libp2p-interop repo first^^

@maschad
Copy link
Member Author

maschad commented Jan 25, 2023 •
edited
Loading

It appears that it needs to be bumped in libp2p-interop repo first^^

Thanks @mpetrunic, turns out @achingbrain had already addressed this I must have overlooked the comment.

This is blocked until libp2p/interop#82 is merged.

@achingbrain
Copy link
Member

achingbrain commented Feb 1, 2023 •
edited
Loading

libp2p/interop#82 has been merged and released, now there are a couple of hundred tedious linting errors to tidy up.

I think we should try to get #1533 in first as fixing all the linting noise here will cause many, many conflicts in that branch so let's pause on this until the circuit relay v2 stuff is in.

@p-shahi p-shahi added status/blocked Unable to be worked further until needs are met and removed status/blocked Unable to be worked further until needs are met labels Feb 28, 2023
@p-shahi
Copy link
Member

p-shahi commented Mar 2, 2023

This is unblocked now that #1533 has been merged @maschad

@maschad maschad marked this pull request as draft March 3, 2023 20:22
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 3, 2023
@maschad
chore: lint the circuit relay files (libp2p#1566)
f03e23a
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 3, 2023
@maschad
chore: lint the circuit relay files (libp2p#1566)
bb9772c
@maschad maschad force-pushed the chore/upgrade-aegir branch from f03e23a to bb9772c Compare March 3, 2023 20:34
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 3, 2023
@maschad
chore: lint connection manager (libp2p#1566)
06c8f45
@maschad maschad mentioned this pull request Mar 3, 2023
Closed
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 3, 2023
@maschad
chore: lint content routing (libp2p#1566)
2bf07a7
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 3, 2023
@maschad
chore: lint identify (libp2p#1566)
6ff2e6b
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 3, 2023
@maschad
chore: lint identify (libp2p#1566)
9ed169b
@maschad maschad force-pushed the chore/upgrade-aegir branch from 6ff2e6b to 9ed169b Compare March 3, 2023 23:20
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 5, 2023
@maschad
chore: lint libp2p main (libp2p#1566)
2f30e3d
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 5, 2023
@maschad
chore: lint nat manager (libp2p#1566)
664e475
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 5, 2023
@maschad
chore: lint the circuit relay files (libp2p#1566)
060a982
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 5, 2023
@maschad
chore: lint connection manager (libp2p#1566)
cb42399
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 5, 2023
@maschad
chore: lint content routing (libp2p#1566)
edd04ba
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 5, 2023
@maschad
chore: lint identify (libp2p#1566)
15992e1
@maschad maschad force-pushed the chore/upgrade-aegir branch from 664e475 to 93fc6d4 Compare March 5, 2023 04:35
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 5, 2023
@maschad
chore: lint libp2p main (libp2p#1566)
3f57142
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 5, 2023
@maschad
chore: lint nat manager (libp2p#1566)
75b71fa
maschad added a commit to maschad/js-libp2p that referenced this pull request Mar 5, 2023
@maschad
chore: lint peer routing (libp2p#1566)
93fc6d4
@maschad maschad force-pushed the chore/upgrade-aegir branch from 93fc6d4 to 92edb4a Compare March 5, 2023 04:36
@maschad maschad marked this pull request as ready for review March 6, 2023 14:55
@maschad
Copy link
Member Author

maschad commented Mar 6, 2023 •
edited
Loading

Thanks @p-shahi , it's ready to be reviewed now @achingbrain @mpetrunic but I think we should look to get #1579 and #1619 merged first

achingbrain
achingbrain approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achingbrain achingbrain merged commit 001af1f into libp2p:master Mar 14, 2023
@maschad maschad deleted the chore/upgrade-aegir branch March 14, 2023 13:40
prathamesh0 pushed a commit to cerc-io/js-libp2p that referenced this pull request Mar 24, 2023
@maschad @achingbrain @prathamesh0
chore: upgrade aegir (libp2p#1566)
2061bb2 
Updates aegir, fixes all linting and dep issues.

Co-authored-by: achingbrain <[email protected]>
@prathamesh0 prathamesh0 mentioned this pull request Mar 24, 2023
Merged
ashwinphatak pushed a commit to cerc-io/js-libp2p that referenced this pull request Mar 24, 2023
@prathamesh0 @maschad @achingbrain
Upgrade aegir and add package lock file (#5)
e449990 
* chore: upgrade aegir (libp2p#1566)

Updates aegir, fixes all linting and dep issues.

Co-authored-by: achingbrain <[email protected]>

* Fix linting errors

* Add package-lock.json

* fix: use @libp2p/keychain module instead of bundling source code (libp2p#1569)

The @libp2p/keychain module has the keychain code split out from this module so use that instead of bundling the code here.

It's also dropped it's dependency on `node-forge` so it's now only in `@libp2p/crypto`.

* Fix dependencies

* Avoid upgrading go-libp2p for interop tests

---------

Co-authored-by: Chad Nehemiah <[email protected]>
Co-authored-by: achingbrain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achingbrain achingbrain achingbrain approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

Assignees

No one assigned

Labels

None yet

Projects

js-libp2p
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maschad @mpetrunic @achingbrain @p-shahi