Reconnect all persisted peers on restart #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `stop_sender`/`stop_receiver` watch channel is used to signal to background tasks that they need to stop as we're about to shut down. Previously, we stored both sides in our `Node` object. However, when restarting the node, this would lead to us cloning a stale `stop_receiver`, i.e., one that still had the change signal set, messing with our shutdown logic on restarts. Here, we instead drop the stored receiver and just create all receivers by `subscribe`ing to the sender where necessary, which fixes the prior bug.
c5cd5fd to
9c1aa7c
Compare
|
LGTM but the new test failed in CI |
While we previously took care of persisting peer details when a channel is opened and if the user signals to `connect` to have the connection persisted, our background task would still only try to reconnect to channel peers. Here, we fix this omission and add a regression test ensuring we'll see the proper behavior going forward.
9c1aa7c to
b1bee0f
Compare
Collaborator
Author
Added a second sleep and now CI fails on the well-known Windows test I yet have to find a solution for... |
wpaulino
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we previously took care of persisting peer details when a channel is opened and if the user signals to
connectto have the connection persisted, our background task would still only try to reconnect to channel peers. Here, we fix this omission and add a regression test ensuring we'll see the proper behavior going forward.Testing the restart behavior also uncovered another minor issue that arose from storing and cloning the
stop_receiverin theNodeobject. To fix this, we drop the receiver end and justsubscribeto the sender when needed.