#336 followups #351
Merged
#336 followups #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4419f46 to
85a1d01
Compare
Collaborator
Author
|
Hmm, the flaky python test seems unrelated, at least seems to work fine locally. |
85a1d01 to
2dabdc3
Compare
slanesuke
approved these changes
Aug 27, 2024
Contributor
slanesuke
left a comment
There was a problem hiding this comment.
Thanks for the help! LGTM
jkczyz
reviewed
Aug 27, 2024
2dabdc3 to
775f8b9
Compare
Previously, the `SendingParamters` field was simply an `Option<u64>`, which however means we could just override it to be `Some`. Here, we have it be `Option<Option<u64>>` which allows the `None` override. As UniFFI doesn't support `Option<Option<..>>`, we work around this via a dedicated `enum` that is only exposed under the `uniffi` feature.
.. as it was used for spontaneous payments only and hence a bit misleading. We drop it for now and see if any users would complain. If so, it would probably be sufficient for it to be an optional parameter on the spontaneous payments methods.
775f8b9 to
b282d42
Compare
Collaborator
Author
|
Squashed without further changes. |
jkczyz
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. a few minor follow-ups to #336.
(cc @slanesuke)