Complete CVE fix for cruise-control-metrics-reporter#2330
Open
shubhi-gupta5 wants to merge 2 commits intolinkedin:mainfrom
Open
Complete CVE fix for cruise-control-metrics-reporter#2330shubhi-gupta5 wants to merge 2 commits intolinkedin:mainfrom
shubhi-gupta5 wants to merge 2 commits intolinkedin:mainfrom
Conversation
kyguy
reviewed
Dec 1, 2025
Contributor
kyguy
left a comment
There was a problem hiding this comment.
@shubhi-gupta5 nice catch! It looks like the CI failed due to a timeout but appears to be unrelated to the PR changes. Could you rebase to retrigger the CI tests?
a114187 to
16475b2
Compare
Author
@kyguy Pushed an empty commit to trigger the CI tests. |
kyguy
approved these changes
Dec 2, 2025
Author
|
Hey @CCisGG , could you take a look at this when you get a chance? I would really appreciate it. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cruise-controlmodule but missed thecruise-control-metrics-reportermodule. This resulted in the vulnerable commons-beanutils 1.9.4 JAR still being present in the container image at/opt/cruise-control/libs/commons-beanutils-1.9.4.jar.cruise-control-metrics-reportermodule, forcing Gradle to use commons-beanutils 1.11.0 (the patched version) instead of the vulnerable 1.9.4 that is transitively pulled by Apache Kafka 4.0.0.Actual Behavior
Currently in container image (built from commit bea2bcb):
$ podman run --rm quay.io/strimzi/kafka:0.48.0-kafka-4.1.0 find / -name "commons-beanutils*.jar" /opt/cruise-control/libs/commons-beanutils-1.9.4.jar ❌ VULNERABLE /opt/kafka/libs/commons-beanutils-1.11.0.jar ✅The vulnerable JAR is coming from the
cruise-control-metrics-reportermodule which lacks the dependency constraint.