Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ› fix: refactor and fix to imporve UX detail #1117

Merged
merged 10 commits into from
Jan 21, 2024
Merged

๐Ÿ› fix: refactor and fix to imporve UX detail #1117

merged 10 commits into from
Jan 21, 2024

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Jan 21, 2024 •
edited
Loading

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore
  • โšก๏ธ perf
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

  1. ไฟฎๅค metadatabase ็š„่ญฆๅ‘Š๏ผŒ้ป˜่ฎค็š„ metadatabase ไธบ https://chat-preview.lobehub.com/
  2. ไผ˜ๅŒ– discover ๅ›พๆ ‡๏ผŒfix [Request] ไธคไธช Logo ็š„ไผ˜ๅŒ–้—ฎ้ข˜ย #537
  3. ้‡ๆž„ url state management ๅฎž็Žฐ๏ผŒ็งป้™ค persist ็š„็”จๆณ•๏ผŒๅบ”่ฏฅ็งปๅŠจ็ซฏ็š„ๆ‰‹ๅŠฟๅŽ้€€้—ฎ้ข˜ๅฏไปฅๆ นๆœฌ่งฃๅ†ณไบ†๏ผ›
  4. ไผ˜ๅŒ–้ƒจๅˆ† store ็š„้€ป่พ‘ๅฎž็Žฐ๏ผ›
  5. ็งป้™ค sessionStore ็š„ hooks ๏ผŒไธๅ†้œ€่ฆๅค„็†ๆฐดๅˆ๏ผ›
  6. ไฟฎๅค่ฟ›ๅ…ฅ / ๆต่งˆๅ™จไผš่ฎฐๅฝ•ๅŽ†ๅฒ็š„ bug
  7. ๆ–ฐๅขž /chat/settings ๅ’Œ /settings ้ข„ๅ–๏ผŒๆๅ‡้กต้ขๅŠ ่ฝฝ้€Ÿๅบฆ๏ผŒrefs: [Bug] ็ฝ‘้กตๆ“ไฝœ่ตทๆฅๆœ‰็‚นๅก้กฟ UIๅพˆๅฅฝ็œ‹ๅฐฑๆ˜ฏๅŠจ็”ปไธๆต็•… ๅกๅก็š„ย #701 (comment)

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Jan 21, 2024 0:47am

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2024 •
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (342da47) 88.61% compared to head (8fd07ce) 89.11%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/store/session/slices/session/action.ts 30.76% 9 Missing โš ๏ธ
src/store/global/slices/common/action.ts 66.66% 2 Missing โš ๏ธ
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
+ Coverage   88.61%   89.11%   +0.50%     
==========================================
  Files         177      170       -7     
  Lines        8354     8207     -147     
  Branches      954      945       -9     
==========================================
- Hits         7403     7314      -89     
+ Misses        951      893      -58

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@lobehubbot
Copy link
Member

๐Ÿ‘ @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@arvinxx arvinxx changed the title Fix/detail ๐Ÿ› fix: refactor and fix to imporve UX detail Jan 21, 2024
@arvinxx arvinxx marked this pull request as draft January 21, 2024 10:39
@arvinxx arvinxx marked this pull request as ready for review January 21, 2024 12:50
@arvinxx arvinxx merged commit a355d2c into main Jan 21, 2024
7 of 8 checks passed
@arvinxx arvinxx deleted the fix/detail branch January 21, 2024 12:52
@lobehubbot
Copy link
Member

โค๏ธ Great PR @arvinxx โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request Jan 21, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v0.120.4 [skip ci]
f752ca8 
### [Version 0.120.4](v0.120.3...v0.120.4)
<sup>Released on **2024-01-21**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Refactor url state management and fix some detail experience.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Refactor url state management and fix some detail experience, closes [#1117](#1117) ([a355d2c](a355d2c))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 0.120.4 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jan 21, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v1.2.4 [skip ci]
3093144 
### [Version&nbsp;1.2.4](v1.2.3...v1.2.4)
<sup>Released on **2024-01-21**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Refactor url state management and fix some detail experience.

#### ๐Ÿ’„ Styles

- **misc**: Update locale and add test for globalStore.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Refactor url state management and fix some detail experience, closes [lobehub#1117](https://github.com/bentwnghk/lobe-chat/issues/1117) ([a355d2c](a355d2c))

#### Styles

* **misc**: Update locale and add test for globalStore, closes [lobehub#1119](https://github.com/bentwnghk/lobe-chat/issues/1119) ([4545cf0](4545cf0))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
miroshar-success added a commit to miroshar-success/OpenAI_Integraion_platform that referenced this pull request Apr 5, 2024
@miroshar-success
๐Ÿ”– chore(release): v0.120.4 [skip ci]
1a643de 
### [Version&nbsp;0.120.4](lobehub/lobe-chat@v0.120.3...v0.120.4)
<sup>Released on **2024-01-21**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Refactor url state management and fix some detail experience.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Refactor url state management and fix some detail experience, closes [#1117](lobehub/lobe-chat#1117) ([a355d2c](lobehub/lobe-chat@a355d2c))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] ไธคไธช Logo ็š„ไผ˜ๅŒ–้—ฎ้ข˜
2 participants
@arvinxx @lobehubbot