Skip to content

Conversation

@colinsurprenant
Copy link
Contributor

Fixes #13

The following example was crashing because of numeric values

$ bin/logstash -e 'input {stdin {codec => json_lines}} filter{split{field => "a"}} output{stdout {codec => rubydebug}}'
...
{"a":[1,2,3]}

This PR fixed the numeric case and also adds an optimization to avoid checking for @target for every cloned events. Also adds corresponding specs.

Copy link
Contributor

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yaauie
Copy link
Contributor

yaauie commented Jan 3, 2019

Changelog & Version Bump please 😄

@colinsurprenant colinsurprenant merged commit 5670ae4 into logstash-plugins:master Jan 4, 2019
@colinsurprenant
Copy link
Contributor Author

Ignoring unrelated build error, published 3.1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split filter not working on an array of numbers

3 participants