Support specifying the ingest host #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrHeinz
approved these changes
Feb 13, 2025
| end | ||
| end | ||
|
|
||
| describe "#write to cloud" do |
Member
There was a problem hiding this comment.
cloud infra is tested should send a chunked request to the Logtail API, here's driver instead of cloud_driver
Suggested change
| describe "#write to cloud" do | |
| describe "#should send a chunked request to the Logtail API using default host" do |
gyfis
reviewed
Feb 13, 2025
Comment on lines
13
to
14
| source_token abcd1234 | ||
| ingesting_host s1234.g1.betterstackdata.com |
There was a problem hiding this comment.
@lazandrei19 if you're stubbing this anyway, let's use the production cluster (s1234.eu-nbg-2.betterstackdata.com)?
PetrHeinz
reviewed
Feb 13, 2025
fluent-plugin-logtail.gemspec
Outdated
| Gem::Specification.new do |s| | ||
| s.name = 'fluent-plugin-logtail' | ||
| s.version = '0.1.1' | ||
| s.version = '0.1.2' |
Member
There was a problem hiding this comment.
It seems we already have 0.2.0 released - https://rubygems.org/gems/fluent-plugin-logtail/versions/0.2.0
Looks like the version wasn't bumped in 778fc64
Suggested change
| s.version = '0.1.2' | |
| s.version = '0.2.1' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.