Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating repository.json #5

Closed
wants to merge 2 commits into from
Closed

Creating repository.json #5

wants to merge 2 commits into from

Conversation

arunoruto
Copy link

@arunoruto arunoruto commented Jul 5, 2020

Creating the repository.json for adding the repository to the add-on store.
Hence an easier installation is possible and even auto updates.
I have forked the project and added the file myself and it works fine.
For testing you can try it: https://github.com/SoulEater45/xiaomi_mi_scale_ha_add_on

arunoruto added 2 commits July 5, 2020 05:14
Creating the repository.json for adding the repository to the add-on store.
Hence an easier installation is possible and even auto updates.
@lolouk44
Copy link
Owner

lolouk44 commented Jul 6, 2020

Thanks a lot for your PR. Having reviewed the requirements though, it's more than just adding a file. I need to update the full repo and move the files in a subfolder. And I see that you updated the maintainer info which I was going to ask you about.
In the end I'll probably end up doing the whole lot at once and as such won't be able to use your PR, but thanks a lot for the effort / contribution, much appreciated.

@lolouk44 lolouk44 closed this Jul 6, 2020
@arunoruto
Copy link
Author

Thats weird, since I forked the project and I was able to build it just finde.
And yes, I copid the template from another project and changed it accordingly.

@lolouk44
Copy link
Owner

lolouk44 commented Jul 6, 2020

I guess I might have been able to get away with just leaving the files in the same folder (root), but I've also got a custom component that I will eventually try and make into an add on so it make sense to put it all under 1 add-on repo (hence the change in the repo name too )
Thanks anyway for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants