fix(ci): remove max-versions-to-keep from winget-releaser#607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
max-versions-to-keepparameter from the WinGet publishing workflow to prevent automatic version deletion issues.Problem
The
max-versions-to-keep: 5parameter in.github/workflows/release.ymlcauseswinget-releaserto automatically delete old versions when the version count exceeds 5. However, this feature has a bug that can incorrectly identify the highest version as "old" and attempt to delete it.Example Issue
See microsoft/winget-pkgs#340410 where:
Solution
Removed the
max-versions-to-keepparameter to:Changes
Code Changes
.github/workflows/release.yml: Removedmax-versions-to-keep: 5parameter and added explanatory commentDocumentation Updates
docs/advanced/release-process.md: Added "WinGet Automatic Version Deletion" section in troubleshootingdocs/zh/advanced/release-process.md: Added Chinese translation of the same sectionTesting
Impact
Checklist
Fixes #340410