Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for editing .env file #218

Merged
merged 6 commits into from
Dec 3, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better stack constuctor parameter order
  • Loading branch information
syko9000 committed Dec 1, 2023
commit 037dd08deca9cbaaf7ac2ffab4acb19dcd3326df
2 changes: 1 addition & 1 deletion backend/socket-handlers/docker-socket-handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ export class DockerSocketHandler extends SocketHandler {
throw new ValidationError("isAdd must be a boolean");
}

const stack = new Stack(server, name, composeYAML, false, composeENV);
const stack = new Stack(server, name, composeYAML, composeENV, false);
stack.save(isAdd);
return stack;
}
Expand Down
4 changes: 2 additions & 2 deletions backend/stack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export class Stack {

protected static managedStackList: Map<string, Stack> = new Map();

constructor(server : DockgeServer, name : string, composeYAML? : string, skipFSOperations = false, composeENV? : string) {
constructor(server : DockgeServer, name : string, composeYAML? : string, composeENV? : string, skipFSOperations = false) {
this.name = name;
this.server = server;
this._composeYAML = composeYAML;
Expand Down Expand Up @@ -322,7 +322,7 @@ export class Stack {
if (!skipFSOperations) {
stack = new Stack(server, stackName);
} else {
stack = new Stack(server, stackName, undefined, true);
stack = new Stack(server, stackName, undefined, undefined, true);
}

stack._status = UNKNOWN;
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/Compose.vue
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ services:
ports:
- "8080:80"
`;
const envDefault = "# VARIABLE: value #comment";
const envDefault = "# VARIABLE=value #comment";

let yamlErrorTimeout = null;

Expand Down
Loading