Skip to content

Conversation

@mzishtiaq
Copy link
Contributor

This PR adds rails ~>6 support.

@mzishtiaq
Copy link
Contributor Author

Hey @luisalima. 👋 😄

@gr8bit
Copy link

gr8bit commented Mar 15, 2021

@mzishtiaq we should probably all be using this instead of the original outdatedbrowser anyway...
https://github.com/mikemaccana/outdated-browser-rework#readme

@luisalima luisalima merged commit 6bbcfdb into luisalima:master Mar 15, 2021
@luisalima
Copy link
Owner

Thanks @mzishtiaq , apologies, my inbox was swamped and I somehow missed this!
@gr8bit thanks for the reference to outdated-browser-rework , didn't know it yet 👍

@gr8bit
Copy link

gr8bit commented Mar 16, 2021

@luisalima Thank you for the merge! Could you publish a new gem as well or should I point my Gemfile to the repo for now?

@mzishtiaq mzishtiaq deleted the feature/rails_6_upgrade branch March 17, 2021 12:12
@mzishtiaq
Copy link
Contributor Author

@luisalima That's not a problem at all. Thank you!

@mzishtiaq
Copy link
Contributor Author

@mzishtiaq we should probably all be using this instead of the original outdatedbrowser anyway...
https://github.com/mikemaccana/outdated-browser-rework#readme

You're right! I will see if I can find some time and update this gem so everyone can benefit from it. :)

@luisalima
Copy link
Owner

@mzishtiaq Just did! Thank you for your help 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants