Fix discount product and variants purchasables query#1487
Merged
alecritson merged 3 commits intolunarphp:0.8from Jan 30, 2024
Merged
Fix discount product and variants purchasables query#1487alecritson merged 3 commits intolunarphp:0.8from
alecritson merged 3 commits intolunarphp:0.8from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
Thanks for this @ryanmitchell I think if it's the exclusions that are causing the issue then the query could either exclude the exclusions or include limitations and as you say conditions. |
Contributor
Author
|
Do you want me to update the scopes to accept an array of types? |
Collaborator
|
Yeah I think that would be beneficial, appreciate it |
alecritson
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the discount query check to only consider limitations, which allows exclusions to continue working.
Maybe this needs extended to conditions too, in which case the scope would need changed to accept an array of types.
Closes #1485