[Patch] [BugFix] fix response handler callback lifetimes #4396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the response handler listener will be triggered correctly even if there is no reference to the handler object in javascript. Making it work the same way as `Promise` object. Introduce unit tests for response handler behavior in both JSI and Lepus runtimes. Tests verify that listener callbacks fire even after the handler object is released, and that delegate invocation occurs as expected. Key changes: - Add BUILD targets and test groups for JS and Lepus response handler tests. - Implement response_handler_in_js_unittest.cc and response_handler_in_lepus_unittest.cc. - Refactor JS handler to avoid weak_from_this usage: - Capture native_app weak_ptr directly and guard against destruction. - Use ApiCallBack and delegate-driven invocation for JS callbacks. - Make ConvertBundleInfoToPiperValue static and require app pointer. - Refactor Lepus handler closure capture to use delegate pointer safely, relying on LazyBundleLoader guarantees. - Fix renderer_functions to copy closure arg to ensure safe asynchronous use. TEST: Added unit tests for both runtimes and wired them into lynx_test. issue: f-6798197892 AutoSubmit: true
6838b09 to
9cab417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.