Provide a way to call Lexer methods from SpannedIter#231
Closed
simvux wants to merge 5 commits intomaciejhirsz:masterfrom
Closed
Provide a way to call Lexer methods from SpannedIter#231simvux wants to merge 5 commits intomaciejhirsz:masterfrom
simvux wants to merge 5 commits intomaciejhirsz:masterfrom
Conversation
Contributor
I prefer this approach because someone might add some method to I'd love this to be merged, ping @maciejhirsz. |
Author
|
I've accidentally done some other stuff on the same branch since I forgot about this PR. But if the project wakes up again then I'll just make a new PR. |
Owner
|
Hey! Instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do you think this is appropriate or would it be better to just manually re-create some of the useful methods/impls such as
Clonesource()slice()?