chore(codegen): error to prevent undesired behavior#303
Merged
maciejhirsz merged 3 commits intomaciejhirsz:masterfrom Apr 26, 2023
Merged
chore(codegen): error to prevent undesired behavior#303maciejhirsz merged 3 commits intomaciejhirsz:masterfrom
maciejhirsz merged 3 commits intomaciejhirsz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @maciejhirsz !
This PR follows what was discussed in #302.
I added a small check in
logos-codegento check for.*or.+patterns. When found, an error is raised with a helpful message that redirects to a solution.I hope the implementation is correct (especially for non-utf8 cases and the fact that I also added a check for
.+).NOTES
tests/tests/binary.rstotests/src/lib.rsbecause I don't think they were ever executed;r"\([^)]*\)", is missing an\to escape the inner);