Use lifetime GAT for Source::Slice#332
Merged
jeertmans merged 2 commits intomaciejhirsz:masterfrom Aug 17, 2023
Merged
Conversation
Collaborator
|
Nice, thanks! I have read about GAT, but not actually used them. do you have an example code that would now work with the new change, and that would not work previously? |
Contributor
Author
|
I think the change in The bigger source of breakages would be that this invalidates any |
Collaborator
|
Could you update Rust's MSRV so that it passes the tests? You can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to write a
Sourceimpl for any type whose slice is a custom type and not a bare reference. For example, seeropey::RopeSlice.Relates to #222.