Skip to content

fix(ci): do not use actions-rs's cargo action#483

Merged
jeertmans merged 2 commits intomasterfrom
fix-ci
Jun 2, 2025
Merged

fix(ci): do not use actions-rs's cargo action#483
jeertmans merged 2 commits intomasterfrom
fix-ci

Conversation

@jeertmans
Copy link
Collaborator

@jeertmans jeertmans commented Jun 2, 2025

Looks like half@2.6.0 was used cargo, even though its dependent package clearly mentions half@2.2 in its Cargo.toml file...

Fixing this with cargo update half@2.6.0 ver 2.4.0.

[dev-dependencies]
└── codspeed-criterion-compat v2.10.1
    ├── codspeed-criterion-compat-walltime v2.10.1
    │   ├── anes v0.1.6
    │   ├── cast v0.3.0
    │   ├── ciborium v0.2.2
    │   │   ├── ciborium-io v0.2.2
    │   │   ├── ciborium-ll v0.2.2
    │   │   │   ├── ciborium-io v0.2.2
    │   │   │   └── half v2.4.0
    │   │   │       └── cfg-if v1.0.0

Looks like this is breaking the CI tests as it does not use the same packages as installed in previous steps.
@jeertmans jeertmans added the continuous integration GitHub workflows and others label Jun 2, 2025
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (c36f20e) to head (af18200).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
- Coverage   49.31%   49.11%   -0.21%     
==========================================
  Files          33       33              
  Lines        2054     2079      +25     
==========================================
+ Hits         1013     1021       +8     
- Misses       1041     1058      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 2, 2025

CodSpeed Performance Report

Merging #483 will not alter performance

Comparing fix-ci (af18200) with master (c36f20e)

Summary

✅ 6 untouched benchmarks

@jeertmans jeertmans merged commit a0c0cd4 into master Jun 2, 2025
41 of 43 checks passed
@jeertmans jeertmans deleted the fix-ci branch June 2, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous integration GitHub workflows and others

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant