Conversation
Signed-off-by: tison <wander4096@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
=======================================
Coverage 65.09% 65.09%
=======================================
Files 29 29
Lines 1825 1825
=======================================
Hits 1188 1188
Misses 637 637 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'll next organize the tests and bences dirs better, and then start to improve the impl code. Perhaps we can leverage some tech like Besides, Before doing anything above, I typically tend to go through the repo setup so that developing in a well-formed structure rather than workaround any if I encount them later. |
|
Hi @tisonkun, thanks for your contribution!
Do you plan to perform those changes here? Or in another PR? |
|
@jeertmans thanks for your review! I'd implement them one by one, not push everything in a big (mud) PR :D |
|
That is, this PR is mergable and I'd prefer to contribute changes one by one to avoid rebase too many times :P |
|
Sure! LGTM :-) Thanks! |
Comments inline.
cc @jeertmans