Skip to content

ci: coalesce styles#533

Merged
jeertmans merged 1 commit intomaciejhirsz:masterfrom
tisonkun:coalesce-ci
Jan 12, 2026
Merged

ci: coalesce styles#533
jeertmans merged 1 commit intomaciejhirsz:masterfrom
tisonkun:coalesce-ci

Conversation

@tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Jan 10, 2026

Comments inline.

cc @jeertmans

Signed-off-by: tison <wander4096@gmail.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 10, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing tisonkun:coalesce-ci (1ff0091) with master (1b23291)

Open in CodSpeed

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.09%. Comparing base (1b23291) to head (1ff0091).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #533   +/-   ##
=======================================
  Coverage   65.09%   65.09%           
=======================================
  Files          29       29           
  Lines        1825     1825           
=======================================
  Hits         1188     1188           
  Misses        637      637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tisonkun
Copy link
Contributor Author

I'll next organize the tests and bences dirs better, and then start to improve the impl code.

Perhaps we can leverage some tech like serde_derive and serde_derive_internal to avoid one more dep level when they are actually shared code.

Besides, Logos provides several cool utility for debugging but they are not quite easy for discovering (graph printer, cli, etc.)

Before doing anything above, I typically tend to go through the repo setup so that developing in a well-formed structure rather than workaround any if I encount them later.

@jeertmans jeertmans added the continuous integration GitHub workflows and others label Jan 12, 2026
@jeertmans
Copy link
Collaborator

Hi @tisonkun, thanks for your contribution!

I'll next organize the tests and bences dirs better, and then start to improve the impl code.

Perhaps we can leverage some tech like serde_derive and serde_derive_internal to avoid one more dep level when they are actually shared code.

Besides, Logos provides several cool utility for debugging but they are not quite easy for discovering (graph printer, cli, etc.)

Before doing anything above, I typically tend to go through the repo setup so that developing in a well-formed structure rather than workaround any if I encount them later.

Do you plan to perform those changes here? Or in another PR?

@tisonkun
Copy link
Contributor Author

@jeertmans thanks for your review!

I'd implement them one by one, not push everything in a big (mud) PR :D

@tisonkun
Copy link
Contributor Author

That is, this PR is mergable and I'd prefer to contribute changes one by one to avoid rebase too many times :P

@jeertmans
Copy link
Collaborator

Sure! LGTM :-) Thanks!

@jeertmans jeertmans merged commit 2906820 into maciejhirsz:master Jan 12, 2026
7 checks passed
@tisonkun tisonkun deleted the coalesce-ci branch January 12, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous integration GitHub workflows and others

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants